Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split cli into moby and linuxkit #1695

Merged
merged 1 commit into from Apr 24, 2017

Conversation

justincormack
Copy link
Member

moby just does the simple build cases, while linuxkit does
push and run.

This allows splitting out just moby.

Signed-off-by: Justin Cormack justin.cormack@docker.com

Copy link
Contributor

@riyazdf riyazdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, LGTM

@justincormack
Copy link
Member Author

Amended the README too to refer to the new tools.

@@ -15,17 +15,18 @@ LinuxKit, a toolkit for building custom minimal, immutable Linux distributions.

## Getting Started

### Build the `moby` tool
### Build the `moby` and `linuxkit` tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a brief explanation of the difference between the linuxkit and moby tools? I realize we'll continue to shuffle things around but might be helpful in the intermediate stage

Copy link
Collaborator

@deitch deitch Apr 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still am trying to wrap my head around it. Is the short form: moby is a tool for building images, and linuxkit is a tool for pushing and running images? So moby == docker build and linuxkit == docker run / docker push?

And if so... why? What do we gain by having 2 distinct tools?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. And the moby tool will be moved and extended to build assemblies other than linux images. This was discussed at length at DockerCon and various meetings after. I'm not sure there is a good writeup yet

Copy link
Member

@rn rn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @riyazdf that a short explanation in the toplevel readme about the difference between the moby and linuxkit tools would be good, but otherwise LGTM

moby just does the simple `build` cases, while `linuxkit` does
`push` and `run`.

Signed-off-by: Justin Cormack <justin.cormack@docker.com>
@justincormack
Copy link
Member Author

Added a very short explanation, will expand when split out (soon).

@justincormack justincormack merged commit b78b5a7 into linuxkit:master Apr 24, 2017
@justincormack justincormack deleted the split-cli branch April 24, 2017 19:12
@alexellis
Copy link
Contributor

Updated tutorial @ http://blog.alexellis.io/boot-linuxkit-in-10-mins/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants